commit d08045db6c08683715801366cfb0efc0ce76e2da
author Andrew Luo <aluo@google.com> Thu Jun 17 12:06:44 2021 -0700
committer Commit Bot <commit-bot@chromium.org> Tue Jun 22 20:33:49 2021 +0000
tree 29191c00a6ebacbee32b301cba60a71989a7955e
parent 9292415c3743fb830bc3c32891a6c6dd545ec5bf

Freshen firmware api bindings.

BUG=None
TEST=None

Change-Id: Ia430a236956cc75e7f2a546b754a5557bde50248
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2970306
Tested-by: Andrew Luo <aluo@chromium.org>
Auto-Submit: Andrew Luo <aluo@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

api/controller/firmware.py

diff --git a/api/controller/firmware.py b/api/controller/firmware.py
index e459f1b..e3cf931 100644
--- a/api/controller/firmware.py
+++ b/api/controller/firmware.py
@@ -67,7 +67,7 @@
   metric.target_name = 'foo'
   metric.platform_name = 'bar'
   fw_section = metric.fw_section.add()
-  fw_section.region = firmware_pb2.FwBuildMetric.FwSection.EC_RO
+  fw_section.region = 'EC_RO'
   fw_section.used = 100
   fw_section.total = 150
 
@@ -110,7 +110,7 @@
   metric.target_name = 'foo'
   metric.platform_name = 'bar'
   fw_section = metric.fw_section.add()
-  fw_section.region = firmware_pb2.FwBuildMetric.FwSection.EC_RO
+  fw_section.region = 'EC_RO'
   fw_section.used = 100
   fw_section.total = 150
 

api/controller/firmware_unittest.py

diff --git a/api/controller/firmware_unittest.py b/api/controller/firmware_unittest.py
index 1567380..2f74b6a 100644
--- a/api/controller/firmware_unittest.py
+++ b/api/controller/firmware_unittest.py
@@ -11,6 +11,7 @@
 from chromite.api import api_config
 from chromite.api.controller import firmware
 from chromite.api.gen.chromite.api import firmware_pb2
+from chromite.api.gen.chromiumos import common_pb2
 from chromite.lib import constants
 from chromite.lib import cros_build_lib
 from chromite.lib import cros_test_lib
@@ -29,7 +30,7 @@
 
   def _GetInput(self,
                 chroot_path=None,
-                fw_location=firmware_pb2.PLATFORM_EC,
+                fw_location=common_pb2.PLATFORM_EC,
                 code_coverage=False):
     """Helper for creating input message."""
     proto = firmware_pb2.BuildAllFirmwareRequest(
@@ -76,7 +77,6 @@
     self.assertEqual(response.metrics.value[0].target_name, 'foo')
     self.assertEqual(response.metrics.value[0].platform_name, 'bar')
     self.assertEqual(len(response.metrics.value[0].fw_section), 1)
-    self.assertEqual(response.metrics.value[0].fw_section[0].region,
-                     firmware_pb2.FwBuildMetric.FwSection.EC_RO)
+    self.assertEqual(response.metrics.value[0].fw_section[0].region, 'EC_RO')
     self.assertEqual(response.metrics.value[0].fw_section[0].used, 100)
     self.assertEqual(response.metrics.value[0].fw_section[0].total, 150)