commit cead28a54a3bec91911033da49d1736475fe784d
author Gilad Arnold <garnold@chromium.org> Fri May 22 10:45:02 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Fri May 22 22:48:21 2015 +0000
tree 46aecc519cfd8a7483db5364d820acab38499b5a
parent 1c832d66980f4fae2c49ecb9e52e9c222a82c115

parallel_emerge: Move variable assignment inside an if-statement.

This variable is only used inside the conditional block, so no reason to
assign it unconditionally.

BUG=brillo:918
TEST=parallel_emerge --root=/build/amd64-host still works.

Change-Id: I8e5489505568df6a70746d96cc22c7675fb72df0
Reviewed-on: https://chromium-review.googlesource.com/272789
Trybot-Ready: Gilad Arnold <garnold@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Commit-Queue: Gilad Arnold <garnold@chromium.org>

scripts/parallel_emerge.py

diff --git a/scripts/parallel_emerge.py b/scripts/parallel_emerge.py
index e3fe210..8910a2a 100644
--- a/scripts/parallel_emerge.py
+++ b/scripts/parallel_emerge.py
@@ -1873,8 +1873,8 @@
   portage_upgrade = False
   root = emerge.settings["ROOT"]
   # pylint: disable=W0212
-  final_db = emerge.depgraph._dynamic_config._filtered_trees[root]['graph_db']
   if root == "/":
+    final_db = emerge.depgraph._dynamic_config._filtered_trees[root]['graph_db']
     for db_pkg in final_db.match_pkgs("sys-apps/portage"):
       portage_pkg = deps_graph.get(db_pkg.cpv)
       if portage_pkg: