commit bf6b36ce3d24bcfda2e4c78addb576752648693e
author Mike Frysinger <vapier@chromium.org> Fri Apr 17 15:45:45 2015 -0400
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Tue May 19 20:29:23 2015 +0000
tree a8d2b94202059c3c51577f12da087ac41395d0df
parent 582c22c05ab761af5b3ce5c0329c3782ab428320

RunCurl: run with --fail by default

In order to get the extended exit code failures for HTTP 4xx and such, we
have to run curl with the --fail option.  It's easy for people to forget
to include this though, so make it an explicit keyword to RunCurl and set
it on by default.

This lets lib.cache abort quickly when given a URL that is 404.

BUG=chromium:478224
TEST=`./cbuildbot/run_tests` passes

Change-Id: I0d0d09828be950536174d9f77c1e4011679578f6
Reviewed-on: https://chromium-review.googlesource.com/266192
Trybot-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

scripts/cros_sdk.py

diff --git a/scripts/cros_sdk.py b/scripts/cros_sdk.py
index 4a99774..106dff8 100644
--- a/scripts/cros_sdk.py
+++ b/scripts/cros_sdk.py
@@ -97,7 +97,7 @@
     content_length = 0
     logging.debug('Attempting download from %s', url)
     result = retry_util.RunCurl(
-        ['-I', url], redirect_stdout=True, redirect_stderr=True,
+        ['-I', url], fail=False, redirect_stdout=True, redirect_stderr=True,
         print_cmd=False)
     successful = False
     for header in result.output.splitlines():
@@ -124,7 +124,7 @@
 
   if current_size < content_length:
     retry_util.RunCurl(
-        ['-f', '-L', '-y', '30', '-C', '-', '--output', tarball_dest, url],
+        ['-L', '-y', '30', '-C', '-', '--output', tarball_dest, url],
         print_cmd=False)
 
   # Cleanup old tarballs now since we've successfull fetched; only cleanup