gconv_strip: fix running under Python 3
Make sure we pass bytes everywhere with the ahocorasick module rather
than mixing strings and bytes. Also turn the list of filenames back
into strings since we process them that way.
BUG=chromium:997354
TEST=running build_image with python3 chromite passes
Cq-Depend: chromium:1927612
Change-Id: I0696a29b65a5ebe6c29659f11c592b5482eb881c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1928611
Tested-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
diff --git a/scripts/gconv_strip_unittest.py b/scripts/gconv_strip_unittest.py
index a0e8160..fcc70e1 100644
--- a/scripts/gconv_strip_unittest.py
+++ b/scripts/gconv_strip_unittest.py
@@ -20,8 +20,8 @@
def testMultipleStringMatch(self):
self.assertEqual(
gconv_strip.MultipleStringMatch(
- ['hell', 'a', 'z', 'k', 'spec'],
- 'hello_from a very special place'),
+ [b'hell', b'a', b'z', b'k', b'spec'],
+ b'hello_from a very special place'),
[True, True, False, False, True])
def testModuleRewrite(self):
@@ -42,7 +42,9 @@
osutils.WriteFile(tmp_gconv_module, data)
gmods = gconv_strip.GconvModules(tmp_gconv_module)
- gmods.Load()
+ self.assertEqual(gmods.Load(), [
+ 'BAR', 'CHAR_A', 'EUROPE', 'FOO', 'charset_A', 'charset_B',
+ 'charset_bar', 'charset_foo'])
self.PatchObject(gconv_strip.lddtree, 'ParseELF', return_value={})
class _StubStat(object):
st_size = 0