chrome_committer: Refactor arg passing.
Pass args individually instead of the arg array.
BUG=chromium:1019968
TEST=lib/chrome_committer_unittest; scripts/chrome_chromeos_lkgm_unittest
Change-Id: I8eb20de1fb5c6cebc2929a163a1be93ba08bbcb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1959094
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
diff --git a/scripts/chrome_chromeos_lkgm_unittest.py b/scripts/chrome_chromeos_lkgm_unittest.py
index 30d2873..a9b5d69 100644
--- a/scripts/chrome_chromeos_lkgm_unittest.py
+++ b/scripts/chrome_chromeos_lkgm_unittest.py
@@ -21,19 +21,10 @@
cros_test_lib.MockTempDirTestCase):
"""Test cros_chromeos_lkgm.Committer."""
- class Args(object):
- """Class for ChromeLKGMComitter args."""
- def __init__(self, workdir, lkgm):
- self.workdir = workdir
- self.lkgm = lkgm
- self.dryrun = False
- self.user_email = 'user@test.org'
-
-
def setUp(self):
"""Common set up method for all tests."""
self.committer = chrome_chromeos_lkgm.ChromeLKGMCommitter(
- ChromeLKGMCommitterTester.Args(self.tempdir, '1001.0.0'))
+ 'user@test.org', self.tempdir, '1001.0.0')
self.lkgm_file = os.path.join(self.tempdir, constants.PATH_TO_CHROME_LKGM)
self.old_lkgm = None
@@ -87,7 +78,7 @@
def testVersionWithChromeBranch(self):
"""Tests passing a version with a chrome branch strips the branch."""
self.committer = chrome_chromeos_lkgm.ChromeLKGMCommitter(
- ChromeLKGMCommitterTester.Args(self.tempdir, '1003.0.0-rc2'))
+ 'user@test.org', self.tempdir, '1003.0.0-rc2')
self.old_lkgm = '1002.0.0'
self.rc.AddCmdResult(partial_mock.In('remote'), returncode=0,