commit b55b703ea065f783c6045a024fda48d9f1902ab8
author Chris McDonald <cjmcdonald@chromium.org> Thu Jun 17 16:41:32 2021 -0600
committer Commit Bot <commit-bot@chromium.org> Fri Jul 16 23:53:37 2021 +0000
tree 0460088cc95ef64cf29472c5156679b269286471
parent d4bdef217e97b8233ef8c56a647c36e1efdf6a8d

cbuildbot: Move Buildbot printing functions to `cbuildbot_alerts` module

Move all of the cbuildbot-specific printing routines out of cros_logging
and in to a new submodule of cbuildbot. Fix up all usages of these
functions to point to the new location.

BUG=b:191490453
TEST=`run_tests`

Change-Id: I5f5f28256b89d2b0500c1c404e2718f33aceaa31
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2973409
Tested-by: Chris McDonald <cjmcdonald@chromium.org>
Commit-Queue: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

scripts/cros_generate_breakpad_symbols.py

diff --git a/scripts/cros_generate_breakpad_symbols.py b/scripts/cros_generate_breakpad_symbols.py
index da2c6b4..70c4bc7 100644
--- a/scripts/cros_generate_breakpad_symbols.py
+++ b/scripts/cros_generate_breakpad_symbols.py
@@ -18,13 +18,14 @@
 
 import collections
 import ctypes
+import logging
 import multiprocessing
 import os
 
+from chromite.cbuildbot import cbuildbot_alerts
 from chromite.lib import build_target_lib
 from chromite.lib import commandline
 from chromite.lib import cros_build_lib
-from chromite.lib import cros_logging as logging
 from chromite.lib import osutils
 from chromite.lib import parallel
 from chromite.lib import signals
@@ -97,7 +98,7 @@
 
   def _CrashCheck(ret, msg):
     if ret < 0:
-      logging.PrintBuildbotStepWarnings()
+      cbuildbot_alerts.PrintBuildbotStepWarnings()
       logging.warning('dump_syms crashed with %s; %s',
                       signals.StrSignal(-ret), msg)
 
@@ -129,7 +130,7 @@
       if result.returncode:
         # A lot of files (like kernel files) contain no debug information,
         # do not consider such occurrences as errors.
-        logging.PrintBuildbotStepWarnings()
+        cbuildbot_alerts.PrintBuildbotStepWarnings()
         _CrashCheck(result.returncode, 'giving up entirely')
         if b'file contains no debugging information' in result.stderr:
           logging.warning('no symbols found for %s', elf_file)