lib: image_lib: drop partition end attribute
The parted & cgpt logic have been returning different values for the
"end" partition attribute. The parted logic returns the offset of
the last byte while cgpt returns the offset of the first byte after
the partition. Basically the parted .end is .start+.size-1 while
the cgpt .end is .start+.size.
Fortunately, no code seems to be using this field, so delete it.
Trying to communicate what this value means doesn't seem worth the
effort if no one ever uses it, and if anyone ever does, their code
can make the choice between "i want the partition's last sector" vs
"i want the first sector after the partition". Usually though code
just wants the first sector (.start) and then iterate over all the
available sectors (.size) starting there.
BUG=b:256896261
TEST=CQ passes
Change-Id: Ieeca1549a15a275598f87c39ad2e6d4f1e774da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4150008
Commit-Queue: Jae Hoon Kim <kimjae@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
diff --git a/scripts/test_image_unittest.py b/scripts/test_image_unittest.py
index 6907549..33d5ca7 100644
--- a/scripts/test_image_unittest.py
+++ b/scripts/test_image_unittest.py
@@ -36,9 +36,9 @@
input="label: dos",
)
fake_partitions = (
- image_lib.PartitionInfo(1, 0, 0, 0, "fs", "STATE", "flag"),
- image_lib.PartitionInfo(2, 0, 0, 0, "fs", "KERN-A", "flag"),
- image_lib.PartitionInfo(3, 0, 0, 0, "fs", "ROOT-A", "flag"),
+ image_lib.PartitionInfo(1, 0, 0, "fs", "STATE", "flag"),
+ image_lib.PartitionInfo(2, 0, 0, "fs", "KERN-A", "flag"),
+ image_lib.PartitionInfo(3, 0, 0, "fs", "ROOT-A", "flag"),
)
self.PatchObject(
image_lib,