commit 9f9fe91211282f053b644b7251037afa55053b1e
author Mike Frysinger <vapier@chromium.org> Mon Sep 09 16:19:55 2019 -0400
committer Commit Bot <commit-bot@chromium.org> Tue Sep 10 12:50:05 2019 +0000
tree 63816186fdef54709e882054b66ed22aa4aa89dd
parent 854130a9d5e590a145dacc491dfd553afac8f161

metrics: add some debug code

We're crashing but it's not entirely clear why.  Lets dump internal
state until we can figure it out.

BUG=chromium:1001909
TEST=unittests pass

Change-Id: I838bc585685688bb614bf1932374774009543f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1793422
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Will Bradley <wbbradley@chromium.org>

api/metrics.py

diff --git a/api/metrics.py b/api/metrics.py
index b092949..739c746 100644
--- a/api/metrics.py
+++ b/api/metrics.py
@@ -11,6 +11,7 @@
 
 from __future__ import print_function
 
+from chromite.lib import cros_logging as logging
 from chromite.utils import metrics
 
 
@@ -40,7 +41,11 @@
       timers[input_event.key] = (input_event.name,
                                  input_event.timestamp_epoch_millis)
     elif input_event.op == metrics.OP_STOP_TIMER:
-      timer = timers.pop(input_event.key)
+      # TODO(wbbradley): Drop the None fallback https://crbug.com/1001909.
+      timer = timers.pop(input_event.key, None)
+      if timer is None:
+        logging.error('%s: stop timer recorded, but missing start timer!?',
+                      input_event.key)
       if timer:
         assert input_event.name == timer[0]
         output_event = output_events.add()