commit 9ea00b58d9479d7e9d20d0239eb7b8d7bd18975e
author Alex Klein <saklein@chromium.org> Wed Feb 24 14:47:22 2021 -0700
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 26 22:18:25 2022 +0000
tree a33784325f321fa5ca06a6d2f78e2cc79443566f
parent 7b910b71a0fe2b64382362bcd850d16cb9d2fd5b

compile_build_api_proto: add compiles test.

Add a test that runs the compile script and verifies it produces
*something* as a quick verification it's working.

BUG=b:187795298
TEST=./run_pytest

Change-Id: I262e5c7485b0b5a06b9585112336ae8ffd164402
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2717371
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Alex Klein <saklein@chromium.org>

api/compile_build_api_proto.py

diff --git a/api/compile_build_api_proto.py b/api/compile_build_api_proto.py
index 41fd216..247ec7a 100644
--- a/api/compile_build_api_proto.py
+++ b/api/compile_build_api_proto.py
@@ -97,7 +97,7 @@
   return os.path.join(constants.CHROMITE_DIR, 'infra', 'proto')
 
 
-def _InstallProtoc(protoc_version: ProtocVersion):
+def InstallProtoc(protoc_version: ProtocVersion):
   """Install protoc from CIPD."""
   if protoc_version is not ProtocVersion.CHROMITE:
     return
@@ -117,7 +117,7 @@
 
     cmd.extend(['-ensure-file', ensure_file])
 
-    cros_build_lib.run(cmd, cwd=constants.CHROMITE_DIR, print_cmd=False)
+    cros_build_lib.dbg_run(cmd, cwd=constants.CHROMITE_DIR)
 
 
 def _CleanTargetDirectory(directory: str):
@@ -292,7 +292,7 @@
   source = os.path.join(_get_proto_dir(protoc_version), 'src')
   protoc_version = protoc_version or ProtocVersion.CHROMITE
 
-  _InstallProtoc(protoc_version)
+  InstallProtoc(protoc_version)
   _CleanTargetDirectory(output)
   _GenerateFiles(source, output, protoc_version, dir_subset)
   _InstallMissingInits(output)