commit 9e41e17ffd4483f1cbebf00e98f09ba12f505740
author George Engelbrecht <engeg@google.com> Thu Nov 18 17:04:22 2021 -0700
committer Commit Bot <commit-bot@chromium.org> Sat Nov 20 00:55:53 2021 +0000
tree fb933d91826730b89a473c1216bb6d11a5de6fb8
parent 0779c99f552a6f9381077f4cd0f9ab53483b6aa6

controller: don't die on no firmware artifacts

If we don't find any firmware builds to upload, warn and return nothing
rather than aborting the whole build.

BUG=b:195415535
TEST=./run_tests.py

Change-Id: I9f26ed5405e62fd83c078345861dbd444f19fcda
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3290886
Tested-by: George Engelbrecht <engeg@google.com>
Auto-Submit: George Engelbrecht <engeg@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jack Neus <jackneus@google.com>
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: George Engelbrecht <engeg@google.com>

api/controller/artifacts_unittest.py

diff --git a/api/controller/artifacts_unittest.py b/api/controller/artifacts_unittest.py
index 99d443f..71ce347 100644
--- a/api/controller/artifacts_unittest.py
+++ b/api/controller/artifacts_unittest.py
@@ -389,9 +389,9 @@
   def testBundleFirmwareNoLogs(self):
     """BundleFirmware dies when no firmware found."""
     self.PatchObject(commands, 'BuildFirmwareArchive', return_value=None)
-    with self.assertRaises(cros_build_lib.DieSystemExit):
-      artifacts.BundleFirmware(self.sysroot_request, self.response,
-                               self.api_config)
+    artifacts.BundleFirmware(self.sysroot_request, self.response,
+                             self.api_config)
+    self.assertEqual(len(self.response.artifacts), 0)
 
 
 class BundleFpmcuUnittestsTest(BundleTestCase):