commit 8cb365aaecb87f9ebefda97a60b08ae4004bffa8
author Alex Klein <saklein@chromium.org> Wed May 15 16:24:53 2019 -0600
committer Commit Bot <commit-bot@chromium.org> Thu May 23 21:10:57 2019 +0000
tree 2846b28e81f9cc4178ac5633bfe1203816a9eb57
parent a59da48d16f5b52cb073d5d4a86af21b6d5f620f

Build API: Standardize return codes.

BUG=chromium:963605
TEST=run_tests

Change-Id: If05654fe56e24425da1b89b8d516cc7ba6bebd3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1615507
Tested-by: Alex Klein <saklein@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Commit-Queue: Alex Klein <saklein@chromium.org>
Reviewed-by: David Burger <dburger@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>

api/controller/sysroot.py

diff --git a/api/controller/sysroot.py b/api/controller/sysroot.py
index 04aa31e..518bac4 100644
--- a/api/controller/sysroot.py
+++ b/api/controller/sysroot.py
@@ -7,6 +7,7 @@
 
 from __future__ import print_function
 
+from chromite.api import controller
 from chromite.api.controller import controller_util
 from chromite.lib import build_target_util
 from chromite.lib import cros_build_lib
@@ -15,9 +16,6 @@
 
 _ACCEPTED_LICENSES = '@CHROMEOS'
 
-# Return codes.
-RC_ERROR = 1
-
 
 def Create(input_proto, output_proto):
   """Create or replace a sysroot."""
@@ -71,7 +69,7 @@
       package_info = output_proto.failed_packages.add()
       controller_util.CPVToPackageInfo(package, package_info)
 
-    return RC_ERROR
+    return controller.RETURN_CODE_UNSUCCESSFUL_RESPONSE_AVAILABLE
 
 
 def InstallPackages(input_proto, output_proto):
@@ -105,4 +103,4 @@
       package_info = output_proto.failed_packages.add()
       controller_util.CPVToPackageInfo(package, package_info)
 
-    return RC_ERROR
+    return controller.RETURN_CODE_UNSUCCESSFUL_RESPONSE_AVAILABLE