commit 8b88e9d5acf6e360c95bb2b846fe8186462f6647
author LaMont Jones <lamontjones@chromium.org> Mon Jun 28 16:37:34 2021 -0600
committer Commit Bot <commit-bot@chromium.org> Thu Jul 01 20:13:44 2021 +0000
tree 06c263b14c7ff019a9134546f261a45600365281
parent f2e2e4942e6d7e5457f7d9963b0ca90aedef79e2

Allow empty sysroot in ArtifactsService/Get

Not all builders (such as firmware-*-cq) create a sysroot.

BUG=None
TEST=unittests pass

Change-Id: I48529398e37bc2223b7c64c39abdbe4df6b32cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2993733
Tested-by: LaMont Jones <lamontjones@chromium.org>
Auto-Submit: LaMont Jones <lamontjones@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Dhanya Ganesh <dhanyaganesh@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: LaMont Jones <lamontjones@chromium.org>

api/controller/artifacts.py

diff --git a/api/controller/artifacts.py b/api/controller/artifacts.py
index 1a62605..6c51d4f 100644
--- a/api/controller/artifacts.py
+++ b/api/controller/artifacts.py
@@ -60,6 +60,11 @@
   output_dir = input_proto.result_path.path.path
 
   sysroot = controller_util.ParseSysroot(input_proto.sysroot)
+  # This endpoint does not currently support any artifacts that are built
+  # without a sysroot being present.
+  if not sysroot.path:
+    return controller.RETURN_CODE_SUCCESS
+
   chroot = controller_util.ParseChroot(input_proto.chroot)
   build_target = controller_util.ParseBuildTarget(
       input_proto.sysroot.build_target)