commit 887ca9391cec34b96af520a431bea62482296925
author Don Garrett <dgarrett@google.com> Thu Jun 22 15:32:31 2017 -0700
committer chrome-bot <chrome-bot@chromium.org> Tue Jun 27 10:55:48 2017 -0700
tree 630acbaabdeb78f2454309716cec774869d53bc8
parent 73486ab16d6cc533224e69bdaad95da05b853b94

remote_try: Remove direct use of options object.

Change the constructor of RemoteTryJob to accept explicit flags,
instead of a reference to the options object. This reduces the
cbuildbot coupling.

BUG=chromium:735720
TEST=run_tests

Change-Id: Ie3cbc2ab2b2c5847d4685bbb9318acf6f19a05ee
Reviewed-on: https://chromium-review.googlesource.com/544629
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

scripts/cbuildbot.py

diff --git a/scripts/cbuildbot.py b/scripts/cbuildbot.py
index 6eef327..b1660a3 100644
--- a/scripts/cbuildbot.py
+++ b/scripts/cbuildbot.py
@@ -1135,7 +1135,19 @@
 
     print('Submitting tryjob...')
     with _SetupConnections(options, build_config):
-      tryjob = remote_try.RemoteTryJob(options, args, patch_pool.local_patches)
+      description = options.remote_description
+      if description is None:
+        description = remote_try.DefaultDescription(
+            options.branch,
+            options.gerrit_patches+options.local_patches)
+
+      tryjob = remote_try.RemoteTryJob(args, patch_pool.local_patches,
+                                       options.pass_through_args,
+                                       options.cache_dir,
+                                       description,
+                                       options.committer_email,
+                                       options.use_buildbucket,
+                                       options.slaves)
       tryjob.Submit(testjob=options.test_tryjob, dryrun=False)
     print('Tryjob submitted!')
     print(('Go to %s to view the status of your job.'