Reland "scripts: Add -d and -m parameters to dump_syms"
This reverts commit 68546b0fd96b3eb37531d3e675b0337f137e8f59.
Reason for revert: Build hang probably fixed in crrev.com/c/4544694.
Original change's description:
> Revert "scripts: Add -d and -m parameters to dump_syms"
>
> This reverts commit a89ee08c1d2f559621865238181551614b891c1b.
>
> Reason for revert: breakpad symbols time out, b/280290608
>
>
> Original change's description:
> > scripts: Add -d and -m parameters to dump_syms
> >
> > This dumps inline frames and ICF data which should generate better
> > server-side crash stacks.
> >
> > BUG=chromium:1410232
> > TEST=cros_generate_breakpad_symbols_unittest.py
> >
> > Change-Id: I711105ec9a189988c8972f4126c96e57cab8839b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4288607
> > Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Reviewed-by: Tim Bain <tbain@google.com>
> > Reviewed-by: Mike Frysinger <vapier@chromium.org>
> > Tested-by: Peter Boström <pbos@chromium.org>
>
> Bug: chromium:1410232, b:280290608
> Change-Id: I4895d2ec7babdbbd129b7a75a9fc806d2416113d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4496484
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Raul Rangel <rrangel@chromium.org>
> Owners-Override: Raul Rangel <rrangel@chromium.org>
> Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
BUG=chromium:1410232, b/280290608
TEST=cros_generate_breakpad_symbols_unittest.py
Change-Id: I8e221dce60c5483833db83a3989c5f68a8b84234
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4566948
Commit-Queue: Peter Boström <pbos@chromium.org>
Tested-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
diff --git a/scripts/cros_generate_breakpad_symbols.py b/scripts/cros_generate_breakpad_symbols.py
index c4154ae..ceae4fe 100644
--- a/scripts/cros_generate_breakpad_symbols.py
+++ b/scripts/cros_generate_breakpad_symbols.py
@@ -584,7 +584,7 @@
num_errors = ctypes.c_int(0)
debug_file_only = not os.path.exists(elf_file)
- cmd_base = [dump_syms_cmd, "-v"]
+ cmd_base = [dump_syms_cmd, "-v", "-d", "-m"]
if strip_cfi:
cmd_base += ["-c"]
# Some files will not be readable by non-root (e.g. set*id /bin/su).