commit 6e97bc08904d07faac95005298c729071ff883e8
author Benjamin Shai <bshai@google.com> Mon Mar 07 21:34:39 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Mar 08 18:59:05 2022 +0000
tree 240ddbf589243cd789df7bb1278980281c0ed1d0
parent 42faf86187bde9c513aaf005550c90095a32338f

build-api: Update miniOS return code

In order to be able to detect miniOS payloads being skipped, we need the
failure_reason, which is only parsed if we use the return code that
indicates a response is available.

BUG=b:217557435
TEST=unit-test

Change-Id: I680ea962b6ced7b66e9cd21816e2c2441d171126
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3508259
Reviewed-by: Greg Edelston <gredelston@google.com>
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Benjamin Shai <bshai@google.com>
Tested-by: Benjamin Shai <bshai@google.com>

api/controller/payload_unittest.py

diff --git a/api/controller/payload_unittest.py b/api/controller/payload_unittest.py
index b1c260c..2b9254d 100644
--- a/api/controller/payload_unittest.py
+++ b/api/controller/payload_unittest.py
@@ -99,6 +99,9 @@
     """Test a miniOS paygen request on an image with no miniOS part."""
     patch = self.PatchObject(paygen_payload_lib, 'PaygenPayload')
     patch.side_effect = paygen_payload_lib.NoMiniOSPartitionException
-    payload.GeneratePayload(self.minios_req, self.result, self.api_config)
+    response_code = payload.GeneratePayload(self.minios_req, self.result,
+                                            self.api_config)
     self.assertEqual(self.result.failure_reason,
                      payload_pb2.GenerationResponse.NOT_MINIOS_COMPATIBLE)
+    self.assertEqual(response_code,
+                     controller.RETURN_CODE_UNSUCCESSFUL_RESPONSE_AVAILABLE)