commit 6c381658e592d0f5abbbe022fba53368dc610b05
author Ningning Xia <nxia@chromium.org> Tue Oct 24 16:03:29 2017 -0700
committer chrome-bot <chrome-bot@chromium.org> Wed Nov 01 16:47:14 2017 -0700
tree cc665c834c6386f98c82abcda1e654c7df74a686
parent 65fdfb83af6ab313b5104a557d053e82266adfa3

builder_status_lib: create BuilderStatusesFetcher to fetch BuilderStatus

First step of spliting the completion_stage into
wait_for_slaves_to_complete_stage and handle_changes_stage. Create
BuilderStatusesFetcher so it can be reused in different stages.

BuildSpecsManager should only wait for slaves to complete or timeout and
then return, shouldn't host the logic to the fetch BuilderStatus of
the slaves.

BUG=chromium:721224
TEST=unit_tests

Change-Id: Ieaae8ab7fc34bd3ed1ee673e75a993ed1533fcc9
Reviewed-on: https://chromium-review.googlesource.com/737519
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

scripts/cbuildbot.py

diff --git a/scripts/cbuildbot.py b/scripts/cbuildbot.py
index 6fd5b79..a6acb83 100644
--- a/scripts/cbuildbot.py
+++ b/scripts/cbuildbot.py
@@ -543,6 +543,8 @@
                                'in conjunction with --debug, the tree status '
                                'will not be ignored as it usually is in a '
                                '--debug run.')
+  # TODO(nxia): crbug.com/778838
+  # cbuildbot doesn't use pickle files anymore, remove this.
   group.add_remote_option('--mock-slave-status',
                           metavar='MOCK_SLAVE_STATUS_PICKLE_FILE',
                           help='Override the result of the _FetchSlaveStatuses '