commit 64ac34c41812e71632e78f2b6f3c6fe286bf55c3
author Alex Klein <saklein@chromium.org> Wed Sep 23 10:21:33 2020 -0600
committer Commit Bot <commit-bot@chromium.org> Fri Sep 25 20:37:05 2020 +0000
tree 64ef0a9e251d2482889ab3168be832b05f2f1e5c
parent 86242bfa491b00b949e97f43f1b1c01379b37881

BuildTargetUnitTest: Only use package atoms, not cpf.

The unittest script only accepts atoms. Discard the version when
it is given.

BUG=chromium:1130818
TEST=./run_pytest

Change-Id: I5ecc7441c7027eae01c216a1f48c91b5a755b6f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2424786
Commit-Queue: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Navil Perez <navil@google.com>
Reviewed-by: Michael Mortensen <mmortensen@google.com>

api/controller/test_unittest.py

diff --git a/api/controller/test_unittest.py b/api/controller/test_unittest.py
index 5a9f434..500d431 100644
--- a/api/controller/test_unittest.py
+++ b/api/controller/test_unittest.py
@@ -123,6 +123,7 @@
         build_target={'name': board}, result_path=result_path,
         chroot={'path': chroot_path, 'cache_dir': cache_dir},
         flags={'empty_sysroot': empty_sysroot},
+        packages=formatted_packages,
         package_blacklist=formatted_blocklist,
     )
 
@@ -192,6 +193,17 @@
       test_controller.BuildTargetUnitTest(input_msg, output_msg,
                                           self.api_config)
 
+  def testInvalidPackageFails(self):
+    """Test missing result path fails."""
+    # Missing result_path.
+    pkg = package_info.PackageInfo(package='bar')
+    input_msg = self._GetInput(board='board', result_path=self.tempdir,
+                               packages=[pkg])
+    output_msg = self._GetOutput()
+    with self.assertRaises(cros_build_lib.DieSystemExit):
+      test_controller.BuildTargetUnitTest(input_msg, output_msg,
+                                          self.api_config)
+
   def testPackageBuildFailure(self):
     """Test handling of raised BuildPackageFailure."""
     tempdir = osutils.TempDir(base_dir=self.tempdir)