commit 611e8b1f8ffa24e43dd7a773719838a99c9ef02f
author Allen Webb <allenwebb@google.com> Wed Sep 13 15:54:52 2023 +0000
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 14 16:10:51 2023 +0000
tree 287221dfa8a68fee0a7d95ab371144e643371dac
parent d20b8173558fad3f9fe8abec50ea8c1ff2f312ad

scripts: package_has_missing_deps: Ignore libstdc++.so

libstdc++.so comes from the toolchain so do not flag it as indicating a
missing dependency.

BUG=b:299471320
TEST=package_has_missing_deps --board=amd64-generic chromeos-base/telemetry

Change-Id: I32b7d2f4716d45d74c814d10e4e0cb135b05cbd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4862659
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Allen Webb <allenwebb@google.com>
Commit-Queue: Allen Webb <allenwebb@google.com>

scripts/package_has_missing_deps.py

diff --git a/scripts/package_has_missing_deps.py b/scripts/package_has_missing_deps.py
index 5162a18..3c62caa 100644
--- a/scripts/package_has_missing_deps.py
+++ b/scripts/package_has_missing_deps.py
@@ -198,7 +198,8 @@
 
     def get_implicit_libs(self):
         """Return a set of .so files that are provided by the system."""
-        implicit_libs = set()
+        # libstdc++ comes from the toolchain so always ignore it.
+        implicit_libs = {"libstdc++.so", "libstdc++.so.6"}
         for dep, from_sdk in (
             ("cross-aarch64-cros-linux-gnu/glibc", True),
             ("cross-armv7a-cros-linux-gnueabihf/glibc", True),