commit 5c702784b8eb900b27abf1808423c874d51b5ada
author Mike Frysinger <vapier@chromium.org> Mon Apr 17 16:20:24 2023 -0400
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 20 14:52:52 2023 +0000
tree 360bf34a1426a3cc96f607fa3dded4c38ead1ccb
parent f91b0f9eeaccbd050e50ecd4b48c8fb928edff8e

scripts: cros_gdb: mark --remote_pid deprecated properly

We deprecated this option by changing the help text, but didn't use
any other communication strategy for users to realize they shouldn't
use it.  Use the new deprecated= argument instead.

BUG=None
TEST=CQ passes

Change-Id: I0721b331e5862044f4acc59cbe3375e74713fa34
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4436750
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Sergey Frolov <sfrolov@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

scripts/cros_gdb.py

diff --git a/scripts/cros_gdb.py b/scripts/cros_gdb.py
index d33280c..ccfca99 100644
--- a/scripts/cros_gdb.py
+++ b/scripts/cros_gdb.py
@@ -670,11 +670,12 @@
         help="Process ID of the (already) running process on the"
         " remote device to which to attach.",
     )
+    # TODO(build): Delete in Jan 2024.
     parser.add_argument(
         "--remote_pid",
         dest="pid",
-        default="",
-        help="Deprecated alias for --pid.",
+        help=argparse.SUPPRESS,
+        deprecated="Use --pid instead.",
     )
     parser.add_argument(
         "--no-ping",