commit 59babdbd3631f2a11f1e3028eda39fa7971ccbcc
author Mike Frysinger <vapier@chromium.org> Fri Sep 06 06:25:50 2019 -0400
committer Commit Bot <commit-bot@chromium.org> Fri Sep 06 23:29:23 2019 +0000
tree 8c9c8b0cf481127b500bfdabeb612869744a531a
parent 2131807c5830419c6964c4988e6f62adc31191c0

handle tempfile.TemporaryFile buffering changes in Python 3

Python 3 renamed the argument from "bufsize" to "buffering" to match
the underlying open function which uses "buffering" in both versions.
Add helpers to handle this minor difference.

BUG=chromium:997354
TEST=`./run_tests` passes, and some more tests pass under Python 3

Change-Id: Idbe5fcc860198e6cc20d7b0a977f71a0872a015e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1789422
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

scripts/upload_symbols.py

diff --git a/scripts/upload_symbols.py b/scripts/upload_symbols.py
index d65edc7..ce52ea7 100644
--- a/scripts/upload_symbols.py
+++ b/scripts/upload_symbols.py
@@ -281,8 +281,8 @@
   file_size = symbol.FileSize()
 
   if file_limit and symbol.FileSize() > file_limit:
-    with tempfile.NamedTemporaryFile(
-        prefix='upload_symbols', bufsize=0,
+    with cros_build_lib.UnbufferedNamedTemporaryFile(
+        prefix='upload_symbols',
         dir=tempdir, delete=False) as temp_sym_file:
 
       temp_sym_file.writelines(