scripts: Excise `cros_logging` module
Remove all usages of `cros_logging` in chromite/scripts and replace them
with the stdlib `logging` module. The NOTICE level is already provided by
the custom Logger subclass initialized in chromite's top level module __init__.py
This change was made by finding all imports of `cros_logging` and
replacing those usages with stdlib `logging` and then running `isort`
over all modified files.
Additionally wrapper3_unittest was modified to copy chromite's __init__.py
verbatim rather than creating an empty init, because code now depends on
the logger definition coming from that file.
BUG=b:191490453
TEST=`run_tests`
Change-Id: I81879290689e51e9836b9c47ffdd88a5a7a0b4e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3042188
Tested-by: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Chris McDonald <cjmcdonald@chromium.org>
diff --git a/scripts/tricium_clang_tidy.py b/scripts/tricium_clang_tidy.py
index de99716..6656592 100644
--- a/scripts/tricium_clang_tidy.py
+++ b/scripts/tricium_clang_tidy.py
@@ -29,6 +29,7 @@
import bisect
import json
+import logging
import multiprocessing
import os
from pathlib import Path
@@ -37,15 +38,13 @@
import sys
import tempfile
import traceback
-from typing import (Any, Dict, Iterable, List, NamedTuple, Optional, Set, Tuple,
- Union)
+from typing import Any, Dict, Iterable, List, NamedTuple, Optional, Set, Tuple, Union
import yaml # pylint: disable=import-error
from chromite.lib import build_target_lib
from chromite.lib import commandline
from chromite.lib import cros_build_lib
-from chromite.lib import cros_logging as logging
from chromite.lib import osutils
from chromite.lib import portage_util
from chromite.lib import workon_helper