commit 593c07440b7d52e35e975ddfab06ef03264b0b34
author Trent Apted <tapted@google.com> Fri May 05 03:50:20 2023 +0000
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat May 06 23:35:24 2023 +0000
tree a9609555a8dcc75b28de78b642ccfd402411d661
parent 5c637c4e0c2f54758affeec05a8092864a3261ad

chromite: Ensure chromite lints (mostly) clean after pylint uprev

 - remove suppressions for obsolete lint warnings
 - rename suppressions that have been split (arguments-differ)
 - suppress most of the "consider using.." warnings
 - delete unused variables on except: lines
 - fix some obvious things

BUG=b:236161656
TEST=./run_tests

Change-Id: I3a4af178b29687be23215452aa19c10aa83cb52e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4505565
Tested-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>

scripts/cros_setup_toolchains.py

diff --git a/scripts/cros_setup_toolchains.py b/scripts/cros_setup_toolchains.py
index 3ebe41d..d3bf0ef 100644
--- a/scripts/cros_setup_toolchains.py
+++ b/scripts/cros_setup_toolchains.py
@@ -227,6 +227,8 @@
                 if target in TARGET_COMPILER_RT_ENABLED:
                     cmd.extend(CROSSDEV_COMPILER_RT_ARGS)
                 if target in TARGET_LLVM_PKGS_ENABLED:
+                    # TODO(b/236161656): Fix.
+                    # pylint: disable-next=consider-using-dict-items
                     for pkg in LLVM_PKGS_TABLE:
                         cmd.extend(LLVM_PKGS_TABLE[pkg])
                 if target in TARGET_GO_ENABLED: