chromite: Ensure chromite lints (mostly) clean after pylint uprev
- remove suppressions for obsolete lint warnings
- rename suppressions that have been split (arguments-differ)
- suppress most of the "consider using.." warnings
- delete unused variables on except: lines
- fix some obvious things
BUG=b:236161656
TEST=./run_tests
Change-Id: I3a4af178b29687be23215452aa19c10aa83cb52e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4505565
Tested-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
diff --git a/scripts/cros_generate_os_release.py b/scripts/cros_generate_os_release.py
index 8f6055f..90d840e 100644
--- a/scripts/cros_generate_os_release.py
+++ b/scripts/cros_generate_os_release.py
@@ -52,6 +52,8 @@
for key, value in default_params.items():
mapping.setdefault(key, value)
+ # TODO(b/236161656): Fix.
+ # pylint: disable-next=consider-using-dict-items
osrelease_content = "\n".join([k + "=" + mapping[k] for k in mapping])
osrelease_content += "\n"
osutils.WriteFile(os_release_path, osrelease_content)