chromite: Ensure chromite lints (mostly) clean after pylint uprev
- remove suppressions for obsolete lint warnings
- rename suppressions that have been split (arguments-differ)
- suppress most of the "consider using.." warnings
- delete unused variables on except: lines
- fix some obvious things
BUG=b:236161656
TEST=./run_tests
Change-Id: I3a4af178b29687be23215452aa19c10aa83cb52e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4505565
Tested-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
diff --git a/api/controller/binhost_unittest.py b/api/controller/binhost_unittest.py
index baef497..d882fbc 100644
--- a/api/controller/binhost_unittest.py
+++ b/api/controller/binhost_unittest.py
@@ -527,6 +527,8 @@
for package in self.dev_install_packages:
# Since a package has a category, such as app-arch/zip-3.0-r3, we
# need to create the packages_dir / category dir as needed.
+ # TODO(b/236161656): Fix.
+ # pylint: disable-next=use-maxsplit-arg
category = package.split(os.sep)[0]
osutils.SafeMakedirs(os.path.join(packages_dir, category))
package_tbz2_file = os.path.join(packages_dir, package) + ".tbz2"