commit 5766d1ba4c24dfd0961723f67bf79156a5dc4f40
author Navil Perez <navil@google.com> Wed May 26 17:38:15 2021 +0000
committer Commit Bot <commit-bot@chromium.org> Thu May 27 22:26:47 2021 +0000
tree 2a9b5f5c15286e1b6034419dc2a26405cee63f49
parent 657ef16ee552dacea47a89693a5933986957d3c2

sysroot: Add dryrun option to InstallPackages endpoint.

Allow calls from the Build API to invoke the build_packages script with
the pretend flag.

BUG=b:189336144
TEST=./run_tests

Change-Id: Ib8901e50bc5c8467cb6b7198656f20a2ffdcb993
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2919899
Reviewed-by: Sean McAllister <smcallis@google.com>
Tested-by: Navil Perez <navil@google.com>
Commit-Queue: Navil Perez <navil@google.com>

api/controller/sysroot.py

diff --git a/api/controller/sysroot.py b/api/controller/sysroot.py
index b6e925c..2f5c73b 100644
--- a/api/controller/sysroot.py
+++ b/api/controller/sysroot.py
@@ -170,6 +170,9 @@
       for x in input_proto.package_indexes
   ]
 
+  # Calculate which packages would have been merged, but don't install anything.
+  dryrun = input_proto.flags.dryrun
+
   if not target_sysroot.IsToolchainInstalled():
     cros_build_lib.Die('Toolchain must first be installed.')
 
@@ -184,7 +187,8 @@
       use_flags=use_flags,
       use_goma=use_goma,
       incremental_build=False,
-      setup_board=False)
+      setup_board=False,
+      dryrun=dryrun)
 
   try:
     sysroot.BuildPackages(build_target, target_sysroot, build_packages_config)
@@ -200,6 +204,10 @@
 
     return controller.RETURN_CODE_UNSUCCESSFUL_RESPONSE_AVAILABLE
 
+  # Return without populating the response if it is a dryrun.
+  if dryrun:
+    return controller.RETURN_CODE_SUCCESS
+
   # Copy goma logs to specified directory if there is a goma_config and
   # it contains a log_dir to store artifacts.
   if input_proto.goma_config.log_dir.dir: