commit 54bd70a9d2c7fd6020bc65383e20edb1d5760cb1
author Michael Mortensen <mmortensen@google.com> Thu Nov 21 14:45:38 2019 -0700
committer Commit Bot <commit-bot@chromium.org> Fri Nov 22 03:28:50 2019 +0000
tree ff89b3b440473ea5ae467b251e14305fc4592a58
parent 8f031aa97d805cc569a3bbee822ad56e291c9b1e

BuildAPI: Add unit tests and mocks for Toolchain Service.

Also fix a few test cases in UploadVettedFDOArtifactsTest that called
UploadEbuildWithAFDOArtifacts by mistake.

BUG=chromium:1000856
TEST=run_tests

Change-Id: I8dc934301bd344ee9f725273161f0fc56c64f4ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1929891
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Michael Mortensen <mmortensen@google.com>
Tested-by: Michael Mortensen <mmortensen@google.com>

api/controller/toolchain_unittest.py

diff --git a/api/controller/toolchain_unittest.py b/api/controller/toolchain_unittest.py
index 709b379..0c5973d 100644
--- a/api/controller/toolchain_unittest.py
+++ b/api/controller/toolchain_unittest.py
@@ -51,6 +51,16 @@
                                             self.validate_only_config)
     patch.assert_not_called()
 
+  def testMockCall(self):
+    """Test that a mock call does not execute logic, returns mock value."""
+    patch = self.PatchObject(toolchain_util, 'OrderfileUpdateChromeEbuild')
+    request = self._GetRequest(
+        build_target=self.board, artifact_type=toolchain_pb2.ORDERFILE)
+    toolchain.UpdateEbuildWithAFDOArtifacts(request, self.response,
+                                            self.mock_call_config)
+    patch.assert_not_called()
+    self.assertEqual(self.response.status, True)
+
   def testWrongArtifactType(self):
     """Test passing wrong artifact type."""
     request = self._GetRequest(
@@ -113,17 +123,26 @@
     """Sanity check that a validate only call does not execute any logic."""
     request = self._GetRequest(
         build_target=self.board, artifact_type=toolchain_pb2.ORDERFILE)
-    toolchain.UpdateEbuildWithAFDOArtifacts(request, self.response,
-                                            self.validate_only_config)
+    toolchain.UploadVettedAFDOArtifacts(request, self.response,
+                                        self.validate_only_config)
     self.command.assert_not_called()
 
+  def testMockCall(self):
+    """Test that a mock call does not execute logic, returns mock value."""
+    request = self._GetRequest(
+        build_target=self.board, artifact_type=toolchain_pb2.ORDERFILE)
+    toolchain.UploadVettedAFDOArtifacts(request, self.response,
+                                        self.mock_call_config)
+    self.command.assert_not_called()
+    self.assertEqual(self.response.status, True)
+
   def testWrongArtifactType(self):
     """Test passing wrong artifact type."""
     request = self._GetRequest(
         build_target=self.board, artifact_type=self.invalid_artifact_type)
     with self.assertRaises(cros_build_lib.DieSystemExit) as context:
-      toolchain.UpdateEbuildWithAFDOArtifacts(request, self.response,
-                                              self.api_config)
+      toolchain.UploadVettedAFDOArtifacts(request, self.response,
+                                          self.api_config)
     self.assertIn('artifact_type (%d) must be in' % self.invalid_artifact_type,
                   str(context.exception))