commit 54bd70a9d2c7fd6020bc65383e20edb1d5760cb1
author Michael Mortensen <mmortensen@google.com> Thu Nov 21 14:45:38 2019 -0700
committer Commit Bot <commit-bot@chromium.org> Fri Nov 22 03:28:50 2019 +0000
tree ff89b3b440473ea5ae467b251e14305fc4592a58
parent 8f031aa97d805cc569a3bbee822ad56e291c9b1e

BuildAPI: Add unit tests and mocks for Toolchain Service.

Also fix a few test cases in UploadVettedFDOArtifactsTest that called
UploadEbuildWithAFDOArtifacts by mistake.

BUG=chromium:1000856
TEST=run_tests

Change-Id: I8dc934301bd344ee9f725273161f0fc56c64f4ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1929891
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Michael Mortensen <mmortensen@google.com>
Tested-by: Michael Mortensen <mmortensen@google.com>

api/controller/toolchain.py

diff --git a/api/controller/toolchain.py b/api/controller/toolchain.py
index faf3646..e123403 100644
--- a/api/controller/toolchain.py
+++ b/api/controller/toolchain.py
@@ -28,7 +28,13 @@
   }[artifact_type]
 
 
-@faux.all_empty
+def _UpdateEbuildWithAFDOArtifactsResponse(_input_proto, output_proto, _config):
+  """Add successful status to the faux response."""
+  output_proto.status = True
+
+
+@faux.success(_UpdateEbuildWithAFDOArtifactsResponse)
+@faux.empty_error
 @validate.require('build_target.name')
 @validate.is_in('artifact_type', _NAMES_FOR_ARTIFACTS)
 @validate.validation_complete
@@ -40,13 +46,18 @@
     output_proto (VerifyAFDOArtifactsResponse): The output proto
     _config (api_config.ApiConfig): The API call config.
   """
-
   board = input_proto.build_target.name
   update_method = _GetMethodForUpdatingArtifacts(input_proto.artifact_type)
   output_proto.status = update_method(board)
 
 
-@faux.all_empty
+def _UploadVettedAFDOArtifactsResponse(_input_proto, output_proto, _config):
+  """Add successful status to the faux response."""
+  output_proto.status = True
+
+
+@faux.success(_UploadVettedAFDOArtifactsResponse)
+@faux.empty_error
 @validate.require('build_target.name')
 @validate.is_in('artifact_type', _NAMES_FOR_ARTIFACTS)
 @validate.validation_complete