Fix naming style
Originally sysmon came from chrome infra using the underscore code
base, so all sysmon code uses this style. sysmon is also basically
independent from the rest of chromite, other than living in the same
repo.
Its not the best situation, but be consistent inside sysmon for now.
BUG=chromium:708293
TEST=Run tests
Change-Id: Ibbc43a13dd9477376462d31f897b7f1ea4263d27
Reviewed-on: https://chromium-review.googlesource.com/473492
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>
diff --git a/scripts/sysmon/git_metrics_unittest.py b/scripts/sysmon/git_metrics_unittest.py
index 0c51045..f3a8305 100644
--- a/scripts/sysmon/git_metrics_unittest.py
+++ b/scripts/sysmon/git_metrics_unittest.py
@@ -27,21 +27,21 @@
self.git_repo._check_output(['init'])
self.git_repo._check_output(['commit', '--allow-empty', '-m', 'hi'])
- def testCollectGitHashTypesAreCorrect(self):
+ def test_collect_git_hash_types_are_correct(self):
"""Tests that collecting the git hash doesn't have type conflicts."""
collector = git_metrics._GitMetricCollector(self.git_dir, '/foo/bar')
# This has the side-effect of checking the types are correct.
collector._collect_commit_hash_metric()
- def testCollectGitTimeTypesAreCorrect(self):
+ def test_collect_git_time_types_are_correct(self):
"""Tests that collecting the git commit time works."""
collector = git_metrics._GitMetricCollector(self.git_dir, '/foo/bar')
# This has the side-effect of checking the types are correct.
collector._collect_timestamp_metric()
- def testCollectGitHashCallsSet(self):
+ def test_collect_git_hash_calls_set(self):
collector = git_metrics._GitMetricCollector(self.git_dir, '/foo/bar')
with mock.patch.object(git_metrics._GitMetricCollector,
@@ -54,7 +54,7 @@
mock.call(commit_hash, {'repo': self.git_dir})
])
- def testCollectGitTimeCallsSet(self):
+ def test_collect_git_time_calls_set(self):
collector = git_metrics._GitMetricCollector(self.git_dir, '/foo/bar')
with mock.patch.object(git_metrics._GitMetricCollector,
'_timestamp_metric',