commit 4feb237ba806ed22f4ef5005f6239e9cda81af91
author Lizzy Presland <zland@google.com> Thu Jan 20 05:16:30 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Feb 01 10:51:45 2022 +0000
tree 387c01a077ab85aa1577fcb6628d8cbc58f79fd9
parent c3bedb4902d45791bdf9e24586470770f2d04b7b

api: Provide pkg logs in BuildTargetUnitTest

Some builders have package build failures in the BuildTargetUnitTest
CI step, and this CL provides the package log locations in these cases.

BUG=b:204816060
TEST=./run_tests
TEST=cq forthcoming

Change-Id: I7ad627f51a2fefdccd4555641be554f669a7e952
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3404957
Reviewed-by: Cindy Lin <xcl@google.com>
Commit-Queue: Lizzy Presland <zland@google.com>
Tested-by: Lizzy Presland <zland@google.com>
Auto-Submit: Lizzy Presland <zland@google.com>

api/controller/controller_util.py

diff --git a/api/controller/controller_util.py b/api/controller/controller_util.py
index d353ee6..3a3b9ea 100644
--- a/api/controller/controller_util.py
+++ b/api/controller/controller_util.py
@@ -9,7 +9,7 @@
 import os
 from typing import TYPE_CHECKING, Union
 
-from chromite.api.gen.chromite.api import sysroot_pb2
+from chromite.api.gen.chromite.api import sysroot_pb2, test_pb2
 from chromite.api.gen.chromiumos import common_pb2
 from chromite.cbuildbot import goma_util
 from chromite.lib import build_target_lib
@@ -192,7 +192,9 @@
 def retrieve_package_log_paths(error: sysroot_lib.PackageInstallError,
                                output_proto: Union[
                                    sysroot_pb2.InstallPackagesResponse,
-                                   sysroot_pb2.InstallToolchainResponse],
+                                   sysroot_pb2.InstallToolchainResponse,
+                                   test_pb2.BuildTargetUnitTestResponse
+                               ],
                                target_sysroot: sysroot_lib.Sysroot) -> None:
   """Get the path to the log file for each package that failed to build.