scripts: Don't expect good symbols from /opt/google/cros-containers/lib
During crostini (tael / tatl) builds, /opt/google/cros-containers/lib
gets .debug files that do not match the binaries. dump_syms fails with
"CRC32 mismatch" errors. Until the problem is resolved, do not expect
good symbols from the libraries in /opt/google/cros-containers/lib.
Also, rewrite _ExpectGoodSymbols() to be based on a list of regexes
instead of having separate code for each directory & file type to be
skipped.
BUG=b:241470012,b:279668555
TEST=Ran on tatl, amd64-generic, arm-generic, arm64-generic, betty-pi-arc,
brya, eve, grunt, hana-arc64, jacuzzi, kevin, octopus. Ensured no
validation failures and no unexpected symbol generation failures. (tatl
still gets "Not all expected files were processed successfully,
missing ASH_CHROME", but that's a separate issue.)
Change-Id: Ib148e0b0cfd3cd3ba02d0b4bc80fe7605d33d5c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4509037
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Tested-by: Ian Barkley-Yeung <iby@chromium.org>
diff --git a/scripts/cros_generate_breakpad_symbols_unittest.py b/scripts/cros_generate_breakpad_symbols_unittest.py
index aee67db..9c7e738 100644
--- a/scripts/cros_generate_breakpad_symbols_unittest.py
+++ b/scripts/cros_generate_breakpad_symbols_unittest.py
@@ -562,6 +562,16 @@
"""Binaries in /usr/local should call _DumpAllowingBasicFallback()"""
self._testBinaryIsInLocalFallback("usr/local", "minidump_stackwalk")
+ def testOptGoogleCrosContainersLibSkip(self):
+ """Binaries in /opt/google/cros-containers/lib as well.
+
+ Binaries in /opt/google/cros-containers/lib should call
+ _DumpAllowingBasicFallback()
+ """
+ self._testBinaryIsInLocalFallback(
+ "opt/google/cros-containers/lib", "libc.so.6"
+ )
+
class ValidateSymbolFileTest(cros_test_lib.TempDirTestCase):
"""Tests ValidateSymbolFile"""