commit 4e29b62239da2b5b557306ea349bf3a1abc36dd4
author Yong Hong <yhong@chromium.org> Mon Feb 05 14:31:10 2018 +0800
committer chrome-bot <chrome-bot@chromium.org> Wed Apr 18 09:30:30 2018 -0700
tree 13f9887151e97d8b653b6fafedc4aa101b7ed13d
parent 84ba9179592f074d1180ae1edbfb63b61f47ca04

cros_sdk: Resolve the tarball URL only if --download is specified.

Resolving the tarball URL is slow, so we should do it only if we need
the url.

BUG=chromium:795449 of sorts
TEST=manually test `cros_sdk` command.

Change-Id: I686f3ebdb9b0c448ba57ad109116986f8b4e9e82
Reviewed-on: https://chromium-review.googlesource.com/903802
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

scripts/cros_sdk.py

diff --git a/scripts/cros_sdk.py b/scripts/cros_sdk.py
index 3bb0fc8..31c29c3 100644
--- a/scripts/cros_sdk.py
+++ b/scripts/cros_sdk.py
@@ -1094,12 +1094,13 @@
     logging.PrintBuildbotStepText(sdk_version)
 
   # Based on selections, determine the tarball to fetch.
-  if options.sdk_url:
-    urls = [options.sdk_url]
-  elif options.bootstrap:
-    urls = GetStage3Urls(sdk_version)
-  else:
-    urls = GetArchStageTarballs(sdk_version)
+  if options.download:
+    if options.sdk_url:
+      urls = [options.sdk_url]
+    elif options.bootstrap:
+      urls = GetStage3Urls(sdk_version)
+    else:
+      urls = GetArchStageTarballs(sdk_version)
 
   # Get URLs for the toolchains overlay, if one is to be used.
   toolchains_overlay_urls = None