commit 4907c8c06f77f5da7476e5f6e0f182ec5cdd02c7
author Greg Edelston <gredelston@google.com> Mon Mar 27 14:53:31 2023 -0600
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Mar 29 16:15:07 2023 +0000
tree 66707a1878772465b129e4653db93ed6e01630fe
parent b568659269883de749e7089de7aecb59a0aaf3ef

SdkService/Uprev: Request source root, not chroot

Compiled BAPI protos to incorporate https://crrev.com/c/4374071.
Updated the SDK Uprev endpoint stub to stop referencing the chroot.
More meaningful logic will come in follow-on CLs.

BUG=b:259445595
TEST=./run_tests

Cq-Depend: chromium:4374071
Change-Id: Ib75b47c8109f35fa50aeb6920b616c5f39a58484
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4375639
Commit-Queue: Greg Edelston <gredelston@google.com>
Tested-by: Greg Edelston <gredelston@google.com>
Reviewed-by: Cindy Lin <xcl@google.com>

api/controller/sdk_unittest.py

diff --git a/api/controller/sdk_unittest.py b/api/controller/sdk_unittest.py
index 67333ee..482aaa5 100644
--- a/api/controller/sdk_unittest.py
+++ b/api/controller/sdk_unittest.py
@@ -498,14 +498,16 @@
 class UprevTestCase(cros_test_lib.MockTestCase, api_config.ApiConfigMixin):
     """Test case for SdkService/Uprev() endpoint."""
 
-    _chroot_path = "/path/to/chroot"
+    _source_root = pathlib.Path("/path/to/checkout/")
     _binhost_gs_bucket = "gs://chromiumos-prebuilts/"
     _latest_version = "2023.02.15.115707"
 
     def setUp(self):
         """Set up the test case."""
-        self._chroot_pb2 = common_pb2.Chroot(path=self._chroot_path)
-        self._chroot = controller_util.ParseChroot(self._chroot_pb2)
+        self._source_root_pb2 = common_pb2.Path(
+            path=str(self._source_root),
+            location=common_pb2.Path.Location.OUTSIDE,
+        )
         self.PatchObject(
             sdk_service,
             "GetLatestVersion",
@@ -519,7 +521,7 @@
     def NewRequest(self, version: str = ""):
         """Return a new UprevRequest with standard inputs."""
         return sdk_pb2.UprevRequest(
-            chroot=self._chroot_pb2,
+            source_root=self._source_root_pb2,
             binhost_gs_bucket=self._binhost_gs_bucket,
             version=version,
         )
@@ -540,7 +542,7 @@
         response = self.NewResponse()
         sdk_controller.Uprev(request, response, self.api_config)
         self._uprev_patch.assert_called_with(
-            self._chroot,
+            self._source_root,
             binhost_gs_bucket=self._binhost_gs_bucket,
             version=specified_version,
         )
@@ -556,7 +558,7 @@
         response = self.NewResponse()
         sdk_controller.Uprev(request, response, self.api_config)
         self._uprev_patch.assert_called_with(
-            self._chroot,
+            self._source_root,
             binhost_gs_bucket=self._binhost_gs_bucket,
             version=self._latest_version,
         )