commit 485a9d23d5e303e658f49e1d69a49472091ccb07
author Jack Neus <jackneus@google.com> Mon Dec 21 03:15:15 2020 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Dec 23 02:02:46 2020 +0000
tree 683d566c80223b87e2d55b7d558be9a299abee3e
parent caf9d649ecc2f45b20569935e71593c3622a3cb0

Add --dest-bucket to chromite/scripts/pushimage.py

Add flag so that dest bucket can be set to chromeos-throwaway-bucket,
so that we can get new release builders running without actually
modifying our production bucket (chromeos-releases).
Also, Use this flag in the PushImage Build API endpoint.

BUG=chromium:1159569
TEST=run_tests

Cq-Depend: chromium:2599476
Change-Id: I594502a111adc0ba65a4683a9695afcd44c9d93c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2599290
Reviewed-by: George Engelbrecht <engeg@google.com>
Commit-Queue: Jack Neus <jackneus@google.com>
Tested-by: Jack Neus <jackneus@google.com>

api/controller/image_unittest.py

diff --git a/api/controller/image_unittest.py b/api/controller/image_unittest.py
index c647e11..6fabccf 100644
--- a/api/controller/image_unittest.py
+++ b/api/controller/image_unittest.py
@@ -415,13 +415,14 @@
 
     request = self._GetRequest(
         dryrun=False, profile='', sign_types=[common_pb2.IMAGE_TYPE_RECOVERY])
+    request.dest_bucket = 'gs://foo'
     image_controller.PushImage(request, self.response, self.api_config)
     patch.assert_called_with(
         request.gs_image_dir,
         request.sysroot.build_target.name,
         dry_run=request.dryrun,
-        profile=request.profile.name,
-        sign_types=['recovery'])
+        sign_types=['recovery'],
+        dest_bucket=request.dest_bucket)
 
   def testCallSucceeds(self):
     """Check that a (dry run) call is made successfully."""