commit 45602c7eeb7c087c17d5a2771396d788bb533ed9
author Mike Frysinger <vapier@chromium.org> Sun Sep 22 02:15:11 2019 -0400
committer Commit Bot <commit-bot@chromium.org> Sun Sep 29 07:03:01 2019 +0000
tree 77b461fca38ed1c7d24aa58ecf9c9297b9c66aee
parent 56d0d6a1f54d698c4df95fbf2b47ff13b91582d2

cros_build_lib: rename RunCommand to run

This aligns with the new subprocess.run API.

RunCommand -> run.
SudoRunCommand -> sudo_run.
DebugRunCommand -> dbg_run.

BUG=chromium:1006587
TEST=`./run_tests` passes

Change-Id: I78ebd4e08176d7874b3d3fe537b6ceb292b0241b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1818782
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>

scripts/cros_setup_toolchains.py

diff --git a/scripts/cros_setup_toolchains.py b/scripts/cros_setup_toolchains.py
index fe67a0a..7e58af3 100644
--- a/scripts/cros_setup_toolchains.py
+++ b/scripts/cros_setup_toolchains.py
@@ -227,7 +227,7 @@
             cmd.extend(LLVM_PKGS_TABLE[pkg])
         cmd.extend(['-t', target])
         # Catch output of crossdev.
-        out = cros_build_lib.RunCommand(
+        out = cros_build_lib.run(
             cmd, print_cmd=False, redirect_stdout=True).output.splitlines()
         # List of tuples split at the first '=', converted into dict.
         conf = dict((k, cros_build_lib.ShellUnquote(v))
@@ -302,9 +302,9 @@
       if config_only:
         # In this case we want to just quietly reinit
         cmd.append('--init-target')
-        cros_build_lib.RunCommand(cmd, print_cmd=False, redirect_stdout=True)
+        cros_build_lib.run(cmd, print_cmd=False, redirect_stdout=True)
       else:
-        cros_build_lib.RunCommand(cmd)
+        cros_build_lib.run(cmd)
 
       configured_targets.append(target)
 
@@ -502,7 +502,7 @@
     if root != '/':
       cmd.extend(['--sysroot=%s' % root, '--root=%s' % root])
     cmd.append('sys-devel/libtool')
-    cros_build_lib.RunCommand(cmd)
+    cros_build_lib.run(cmd)
   else:
     logging.debug('Libtool is up-to-date; no need to rebuild')
 
@@ -552,7 +552,7 @@
     cmd.extend(['--sysroot=%s' % root, '--root=%s' % root])
 
   cmd.extend(packages)
-  cros_build_lib.RunCommand(cmd)
+  cros_build_lib.run(cmd)
   return True
 
 
@@ -597,7 +597,7 @@
     if root != '/':
       cmd.extend(['--sysroot=%s' % root, '--root=%s' % root])
     cmd.extend(packages)
-    cros_build_lib.RunCommand(cmd)
+    cros_build_lib.run(cmd)
   else:
     logging.info('Nothing to clean!')
 
@@ -641,7 +641,7 @@
       if root != '/':
         extra_env['ROOT'] = root
       cmd = ['%s-config' % package, '-c', target]
-      result = cros_build_lib.RunCommand(
+      result = cros_build_lib.run(
           cmd, print_cmd=False, redirect_stdout=True, extra_env=extra_env)
       current = result.output.splitlines()[0]
 
@@ -649,7 +649,7 @@
       extra_env = {'ROOT': root} if root != '/' else None
       if current != desired and current != '9999':
         cmd = [package + '-config', desired]
-        cros_build_lib.RunCommand(cmd, print_cmd=False, extra_env=extra_env)
+        cros_build_lib.run(cmd, print_cmd=False, extra_env=extra_env)
 
 
 def ExpandTargets(targets_wanted):