commit 445ae3ca5f3e1d6787b4d5f86d535e61a3845009
author Alex Klein <saklein@chromium.org> Wed Jan 08 16:40:43 2020 -0700
committer Commit Bot <commit-bot@chromium.org> Thu Jan 09 22:05:23 2020 +0000
tree 3346d1927d1811526140f58f6115524eaf1768d8
parent aa566242be193e505a5adb1217a2f85049673f48

Packages controller: Add logging to version endpoint

Checkins after each fetch for debugging, and to provide approximate
timings for each fetch.

BUG=None
TEST=cq

Change-Id: I86da68c411c442e509574c2836715872ddccdb91
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1992731
Tested-by: Alex Klein <saklein@chromium.org>
Auto-Submit: Alex Klein <saklein@chromium.org>
Commit-Queue: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Michael Mortensen <mmortensen@google.com>

api/controller/packages.py

diff --git a/api/controller/packages.py b/api/controller/packages.py
index dc9e617..43ee02a 100644
--- a/api/controller/packages.py
+++ b/api/controller/packages.py
@@ -15,6 +15,7 @@
 from chromite.lib import build_target_util
 from chromite.lib import constants
 from chromite.lib import cros_build_lib
+from chromite.lib import cros_logging as logging
 from chromite.lib.uprev_lib import GitRef
 from chromite.service import packages
 
@@ -156,22 +157,33 @@
 def GetTargetVersions(input_proto, output_proto, _config):
   """Returns the target versions."""
   build_target = controller_util.ParseBuildTarget(input_proto.build_target)
+  # Android version.
   android_version = packages.determine_android_version([build_target])
+  logging.info('Found android version: %s', android_version)
   if android_version:
     output_proto.android_version = android_version
+  # Android branch version.
   android_branch_version = packages.determine_android_branch(build_target)
+  logging.info('Found android branch version: %s', android_branch_version)
   if android_branch_version:
     output_proto.android_branch_version = android_branch_version
+  # Android target version.
   android_target_version = packages.determine_android_target(build_target)
+  logging.info('Found android target version: %s', android_target_version)
   if android_target_version:
     output_proto.android_target_version = android_target_version
+
   # TODO(crbug/1019770): Investigate cases where builds_chrome is true but
   # chrome_version is None.
   builds_chrome = packages.builds(constants.CHROME_CP, build_target)
   if builds_chrome:
+    # Chrome version fetch.
     chrome_version = packages.determine_chrome_version(build_target)
+    logging.info('Found chrome version: %s', chrome_version)
     if chrome_version:
       output_proto.chrome_version = chrome_version
+
+  # The ChromeOS version info.
   output_proto.platform_version = packages.determine_platform_version()
   output_proto.milestone_version = packages.determine_milestone_version()
   output_proto.full_version = packages.determine_full_version()