commit 40aea81320814ea604b6cd60597e320b89ebdd3b
author Greg Edelston <gredelston@google.com> Mon Mar 27 16:34:35 2023 -0600
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Mar 30 22:44:03 2023 +0000
tree 55dd39c1666ad6ce0e8e7f7b5a691faf8cc55d13
parent 3763bf2d18ddde26a3b66216c2034828f63bd274

SdkService/Uprev: Uprev the local SDK version file

BUG=b:259445595
TEST=./run_tests
TEST=Ran the endpoint on my local machine. Verified that the local SDK
version file was modified in-place, and that the output proto contained
the modified file and updated version.

Change-Id: I83b85b349cef26b9f99fa5b2fc7a9cd241192242
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4375650
Tested-by: Greg Edelston <gredelston@google.com>
Reviewed-by: Cindy Lin <xcl@google.com>
Commit-Queue: Cindy Lin <xcl@google.com>
Auto-Submit: Greg Edelston <gredelston@google.com>
Commit-Queue: Greg Edelston <gredelston@google.com>

api/controller/sdk.py

diff --git a/api/controller/sdk.py b/api/controller/sdk.py
index 0fb9dda..6f9ab40 100644
--- a/api/controller/sdk.py
+++ b/api/controller/sdk.py
@@ -182,22 +182,30 @@
 @faux.all_empty
 @validate.require("source_root")
 @validate.require("binhost_gs_bucket")
+@validate.eq("source_root.location", common_pb2.Path.Location.OUTSIDE)
 @validate.validation_complete
 def Uprev(input_proto, output_proto, _config):
-    """Update the SDK version and prebuilt files to point to the latest SDK."""
-    target_version = input_proto.version or sdk.GetLatestVersion()
+    """Update SDK version file and prebuilt files to point to the latest SDK.
+
+    Files will be changed locally, but not committed.
+    """
+    # If the UprevRequest did not specify a target version,
+    # check the remote SDK version file on Google Cloud Storage for the latest
+    # uprev target.
+    target_version = input_proto.version or sdk.GetLatestUprevTargetVersion()
+
+    # The main uprev logic occurs in service/sdk.py.
     modified_files = sdk.UprevSdkAndPrebuilts(
         pathlib.Path(input_proto.source_root.path),
         binhost_gs_bucket=input_proto.binhost_gs_bucket,
         version=target_version,
     )
+
+    # Populate the UprevResponse object with the modified files.
     for modified_file in modified_files:
-        output_proto.modified_files.add(
-            common_pb2.Path(
-                path=str(modified_file),
-                location=common_pb2.Path.OUTSIDE,
-            )
-        )
+        proto_path = output_proto.modified_files.add()
+        proto_path.path = str(modified_file)
+        proto_path.location = common_pb2.Path.OUTSIDE
     output_proto.version = target_version