gerrit: allow for instantiation of any GoB by base name
Since all GoB services follow the same naming style, all that as an input
for creating a GoB helper. Then extend the gerrit commandline interface
to allow for accepting of any remote name.
BUG=chromium:327217
TEST=`./buildbot/run_tests` passes
TEST=`gerrit --gob android inspect 74061` inspects https://android-review.googlesource.com/74061
Change-Id: Ifea8d859ea223097a6772b036af3739bc3920e5d
Reviewed-on: https://chromium-review.googlesource.com/185830
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
diff --git a/scripts/gerrit.py b/scripts/gerrit.py
index 70829ab..604a53f 100644
--- a/scripts/gerrit.py
+++ b/scripts/gerrit.py
@@ -296,11 +296,11 @@
parser = commandline.ArgumentParser(usage=usage)
parser.add_argument('-i', '--internal', dest='gob', action='store_const',
- const=constants.INTERNAL_REMOTE,
+ const=constants.INTERNAL_GOB_INSTANCE,
help='Query internal Chromium Gerrit instance')
parser.add_argument('-g', '--gob',
help='Gerrit (on borg) instance to query (default: %s)' %
- (constants.EXTERNAL_REMOTE))
+ (constants.EXTERNAL_GOB_INSTANCE))
parser.add_argument('--sort', default='number',
help='Key to sort on (number, project)')
parser.add_argument('-v', '--verbose', default=False, action='store_true',
@@ -320,13 +320,13 @@
args = opts.args
if len(args) > 1:
if args[1][0] == '*':
- opts.gob = constants.INTERNAL_REMOTE
+ opts.gob = constants.INTERNAL_GOB_INSTANCE
args[1] = args[1][1:]
if opts.gob is None:
- opts.gob = constants.EXTERNAL_REMOTE
+ opts.gob = constants.EXTERNAL_GOB_INSTANCE
- opts.gerrit = gerrit.GetGerritHelper(opts.gob, print_cmd=opts.debug)
+ opts.gerrit = gerrit.GetGerritHelper(gob=opts.gob, print_cmd=opts.debug)
opts.Freeze()
# Now look up the requested user action and run it.