Fix some lint warnings in chromite.
This picked up tiny bit of dead code in fwbuddy.py that is resolved by
adding `check=False` so that cros_build_lib.run doesn't throw an
exception for non-zero command return codes.
With this, the following command reports no errors:
cros lint --exclude="contrib/*" --exclude='third_party/*' \
--exclude="sdk/bin/*" --include='*.py' --exclude="*" .
BUG=b:298875552
TEST=CQ
Change-Id: Ic8121e8a438669c8ecb2a883bfa5c4d7f3430057
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4835735
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Tested-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sean Carpenter <seancarpenter@google.com>
diff --git a/scripts/replication_util_unittest.py b/scripts/replication_util_unittest.py
index 8a4d002..7c89344 100644
--- a/scripts/replication_util_unittest.py
+++ b/scripts/replication_util_unittest.py
@@ -9,12 +9,7 @@
from chromite.third_party.google.protobuf import json_format
-from chromite.api.gen.config.replication_config_pb2 import (
- FILE_TYPE_OTHER,
- FileReplicationRule,
- REPLICATION_TYPE_COPY,
- ReplicationConfig,
-)
+from chromite.api.gen.config import replication_config_pb2
from chromite.lib import constants
from chromite.lib import cros_test_lib
from chromite.lib import osutils
@@ -22,6 +17,10 @@
D = cros_test_lib.Directory
+FILE_TYPE_OTHER = replication_config_pb2.FILE_TYPE_OTHER
+FileReplicationRule = replication_config_pb2.FileReplicationRule
+REPLICATION_TYPE_COPY = replication_config_pb2.REPLICATION_TYPE_COPY
+ReplicationConfig = replication_config_pb2.ReplicationConfig
class RunTest(cros_test_lib.MockTempDirTestCase):