Fix some lint warnings in chromite.
This picked up tiny bit of dead code in fwbuddy.py that is resolved by
adding `check=False` so that cros_build_lib.run doesn't throw an
exception for non-zero command return codes.
With this, the following command reports no errors:
cros lint --exclude="contrib/*" --exclude='third_party/*' \
--exclude="sdk/bin/*" --include='*.py' --exclude="*" .
BUG=b:298875552
TEST=CQ
Change-Id: Ic8121e8a438669c8ecb2a883bfa5c4d7f3430057
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4835735
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Tested-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sean Carpenter <seancarpenter@google.com>
diff --git a/api/controller/toolchain.py b/api/controller/toolchain.py
index 910612b..218c60f 100644
--- a/api/controller/toolchain.py
+++ b/api/controller/toolchain.py
@@ -13,10 +13,10 @@
from chromite.api import faux
from chromite.api import validate
from chromite.api.controller import controller_util
+from chromite.api.gen.chromite.api import artifacts_pb2
from chromite.api.gen.chromite.api import toolchain_pb2
-from chromite.api.gen.chromite.api.artifacts_pb2 import PrepareForBuildResponse
-from chromite.api.gen.chromiumos.builder_config_pb2 import BuilderConfig
-from chromite.api.gen.chromiumos.common_pb2 import PackageInfo
+from chromite.api.gen.chromiumos import builder_config_pb2
+from chromite.api.gen.chromiumos import common_pb2
from chromite.lib import cros_build_lib
from chromite.lib import toolchain as toolchain_lib
from chromite.lib import toolchain_util
@@ -26,6 +26,11 @@
if TYPE_CHECKING:
from chromite.api import api_config
+
+PrepareForBuildResponse = artifacts_pb2.PrepareForBuildResponse
+BuilderConfig = builder_config_pb2.BuilderConfig
+PackageInfo = common_pb2.PackageInfo
+
# TODO(b/229665884): Move the implementation details for most/all endpoints to:
# chromite/services/toolchain.py
# This migration has been done for linting endpoints but not yet for others.