commit 325e441f3fd6410078d4b81f5fec42ce03a114ea
author Greg Edelston <gredelston@google.com> Thu May 04 16:22:10 2023 -0600
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri May 05 15:51:24 2023 +0000
tree 7216957900758c888edc5078d39b2072de4d439e
parent d82750b59fb1281b933a7c3b79baa42077e688e7

scripts: upload_prebuilts: sync remote SDK file

Oops, I accidentally merged a bug one month ago, and now the remote
SDK file is a month stale. See attached bug for details. The correct
behavior is to sync the remote file unless we specify not to.

Also added test coverage.

BUG=b:280879394
TEST=./run_tests

Change-Id: I3c91c70a1540e4129c0992e09d9289f8ea0c3087
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4505917
Auto-Submit: Greg Edelston <gredelston@google.com>
Tested-by: Greg Edelston <gredelston@google.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>

scripts/upload_prebuilts.py

diff --git a/scripts/upload_prebuilts.py b/scripts/upload_prebuilts.py
index 1c9a7b2..fc80dc3 100644
--- a/scripts/upload_prebuilts.py
+++ b/scripts/upload_prebuilts.py
@@ -26,7 +26,7 @@
 import os
 from pathlib import Path
 import tempfile
-from typing import Optional
+from typing import Optional, Tuple
 
 from chromite.cbuildbot import cbuildbot_alerts
 from chromite.cbuildbot import commands
@@ -813,7 +813,7 @@
         namespace.slave_targets[-1].profile = values
 
 
-def ParseOptions(argv):
+def ParseOptions(argv) -> Tuple[argparse.Namespace, Optional[BuildTarget]]:
     """Returns options given by the user and the target specified.
 
     Args:
@@ -931,6 +931,7 @@
     parser.add_argument(
         "--sync-remote-latest-sdk-file",
         action="store_true",
+        default=True,
         help="Sync the remote latest SDK file on GS://. (Default)",
     )
     parser.add_argument(