commit 2f01e42cf4f3f27a03418e414321a9a8f5155b3a
author Eashan Bhatt <eashanbhatt@google.com> Thu Jul 25 10:31:04 2019 -0700
committer Commit Bot <commit-bot@chromium.org> Tue Jul 30 01:25:53 2019 +0000
tree 4a9d891e9dde619dea1b1d7d8ecb888a39fa485c
parent d186d717e4bc39377c582bdf99ff4c5ac0c1674b

cros_build_lib: Add strict to GetBoard()

Exits with an error message when the board is not specified and a
default board does not exist when strict is true.

BUG=chromium:968169
TEST=manual

Change-Id: I072c5b55b7204582c97a847f5c5da2a1ec728205
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1718831
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Eashan Bhatt <eashanbhatt@google.com>
Tested-by: Eashan Bhatt <eashanbhatt@google.com>

scripts/cros_gdb.py

diff --git a/scripts/cros_gdb.py b/scripts/cros_gdb.py
index 8e63221..b1edc13 100644
--- a/scripts/cros_gdb.py
+++ b/scripts/cros_gdb.py
@@ -174,7 +174,8 @@
     if not self.board:
       if self.remote:
         self.board = cros_build_lib.GetBoard(device_board=device.board,
-                                             override_board=self.board)
+                                             override_board=self.board,
+                                             strict=True)
       else:
         raise GdbCannotDetectBoardError('Cannot determine which board to use. '
                                         'Please specify the with --board flag.')