commit 2e91e5260617849475dc0a4c024f4efc5038566f
author Alex Klein <saklein@chromium.org> Fri Jan 14 09:22:03 2022 -0700
committer Commit Bot <commit-bot@chromium.org> Fri Feb 18 04:31:17 2022 +0000
tree 9220673fe66a89735b08a85c6d025826806f71b0
parent e7755ca3dd24921f2af635e0959fddfb26720816

BuildTargetUnitTest: Stop generating unit_tests.tar

The archive is no longer needed for the fuzzers, and we don't
upload it on the LUCI builders, so stop generating it.

BUG=b:217211026
TEST=CQ, run_tests

Change-Id: Iede8ec368d3fba025e80a969f182bed5aa12b976
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3386363
Reviewed-by: Lizzy Presland <zland@google.com>
Tested-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Alex Klein <saklein@chromium.org>

api/controller/test_unittest.py

diff --git a/api/controller/test_unittest.py b/api/controller/test_unittest.py
index c12a608..310ffab 100644
--- a/api/controller/test_unittest.py
+++ b/api/controller/test_unittest.py
@@ -196,23 +196,6 @@
     self.assertEqual(response.failed_packages[1].category, 'cat')
     self.assertEqual(response.failed_packages[1].package_name, 'pkg')
 
-  def testNoArgumentFails(self):
-    """Test no arguments fails."""
-    input_msg = self._GetInput()
-    output_msg = self._GetOutput()
-    with self.assertRaises(cros_build_lib.DieSystemExit):
-      test_controller.BuildTargetUnitTest(input_msg, output_msg,
-                                          self.api_config)
-
-  def testNoResultPathFails(self):
-    """Test missing result path fails."""
-    # Missing result_path.
-    input_msg = self._GetInput(board='board')
-    output_msg = self._GetOutput()
-    with self.assertRaises(cros_build_lib.DieSystemExit):
-      test_controller.BuildTargetUnitTest(input_msg, output_msg,
-                                          self.api_config)
-
   def testInvalidPackageFails(self):
     """Test missing result path fails."""
     # Missing result_path.
@@ -277,8 +260,8 @@
 
     pkgs = ['foo/bar', 'cat/pkg']
     blocklist = [package_info.SplitCPV(p, strict=False) for p in pkgs]
-    input_msg = self._GetInput(board='board', result_path=self.tempdir,
-                               empty_sysroot=True, blocklist=blocklist)
+    input_msg = self._GetInput(board='board', empty_sysroot=True,
+                               blocklist=blocklist)
     output_msg = self._GetOutput()
 
     rc = test_controller.BuildTargetUnitTest(input_msg, output_msg,
@@ -291,21 +274,15 @@
     """Test BuildTargetUnitTest successful call."""
     pkgs = ['foo/bar', 'cat/pkg']
     packages = [package_info.SplitCPV(p, strict=False) for p in pkgs]
-    input_msg = self._GetInput(
-        board='board', result_path=self.tempdir, packages=packages)
+    input_msg = self._GetInput(board='board', packages=packages)
 
     result = test_service.BuildTargetUnitTestResult(0, None)
     self.PatchObject(test_service, 'BuildTargetUnitTest', return_value=result)
 
-    tarball_result = os.path.join(input_msg.result_path, 'unit_tests.tar')
-    self.PatchObject(test_service, 'BuildTargetUnitTestTarball',
-                     return_value=tarball_result)
-
     response = self._GetOutput()
     test_controller.BuildTargetUnitTest(input_msg, response,
                                         self.api_config)
-    self.assertEqual(response.tarball_path,
-                     os.path.join(input_msg.result_path, 'unit_tests.tar'))
+    self.assertFalse(response.failed_packages)
 
 
 class DockerConstraintsTest(cros_test_lib.MockTestCase):