commit 2c238b576de04f9812957e930964f7bf6ad980e4
author Navil Perez <navil@google.com> Wed Mar 17 16:33:12 2021 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Mar 30 00:06:04 2021 +0000
tree 5b5c8dc67182af61ee57af055144274c5d2c9bad
parent 03af708739aced6c5632a2ca17daacd4e734e33d

dependency: List endpoint use new depgraph class.

Begin using the new depgraph class to get the sysroot dependencies
relevant to a given set of source paths.

BUG=chromium:1132917, chromium:1149921
TEST=./run_pytest, led job

Change-Id: Ic92a9b9d2acd056084037cfa3bca5aea0ce42c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2675230
Tested-by: Navil Perez <navil@google.com>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Navil Perez <navil@google.com>

api/controller/dependency_unittest.py

diff --git a/api/controller/dependency_unittest.py b/api/controller/dependency_unittest.py
index b61b296..f1f44af 100644
--- a/api/controller/dependency_unittest.py
+++ b/api/controller/dependency_unittest.py
@@ -17,6 +17,7 @@
 from chromite.lib import cros_build_lib
 from chromite.lib import cros_test_lib
 from chromite.lib import osutils
+from chromite.lib.parser import package_info
 from chromite.service import dependency as dependency_service
 
 pytestmark = cros_test_lib.pytestmark_inside_only
@@ -187,26 +188,28 @@
 
   def testListResponse(self):
     """Test calls helper method with correct args."""
-    mock_get_deps = self.PatchObject(
-        dependency_service, 'GetDependencies', return_value=['foo/bar-1.2.3'])
     sysroot = sysroot_pb2.Sysroot(
         path=self.sysroot, build_target=self.build_target)
     path = '/path'
-    package = common_pb2.PackageInfo(category='foo', package_name='bar')
+    return_package_info = package_info.parse('foo/bar-1.2.3')
+    return_package_info_proto = common_pb2.PackageInfo(
+        category='foo', package_name='bar', version='1.2.3')
+    mock_get_deps = self.PatchObject(
+        dependency_service,
+        'GetDependencies',
+        return_value=[return_package_info])
+
+    input_package_info_proto = common_pb2.PackageInfo(
+        category='foo', package_name='bar')
+    input_package_info = package_info.parse('foo/bar')
     input_proto = depgraph_pb2.ListRequest(
         sysroot=sysroot,
         src_paths=[
-            depgraph_pb2.SourcePath(path='/path'),
+            depgraph_pb2.SourcePath(path=path),
         ],
-        packages=[package])
+        packages=[input_package_info_proto])
     dependency.List(input_proto, self.response, self.api_config)
     mock_get_deps.assert_called_once_with(
-        self.sysroot,
-        build_target=controller_util.ParseBuildTarget(self.build_target),
-        src_paths=[path],
-        packages=[controller_util.PackageInfoToCPV(package)])
-    expected_deps = [
-        common_pb2.PackageInfo(
-            category='foo', package_name='bar', version='1.2.3')
-    ]
-    self.assertCountEqual(expected_deps, self.response.package_deps)
+        self.sysroot, src_paths=[path], packages=[input_package_info])
+    self.assertCountEqual([return_package_info_proto],
+                          self.response.package_deps)