commit 2b1fed5d1720a9366b260366a1ac03391d76b16f
author Mike Frysinger <vapier@chromium.org> Wed Apr 27 02:15:33 2022 -0400
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Apr 30 03:38:47 2022 +0000
tree d59e50af9f5ff9d839ac111f586c0e1a1a276706
parent a8d9fd271f64257a857db7929508a2cea588c49c

cros_install_debug_syms: delay sudo until after option parsing

This makes --help faster and other error checking (like --board).

BUG=None
TEST=CQ passes

Change-Id: I053bc31a09b1bd2a318f6a5bd6f7c9e4c70cca3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3606479
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>

scripts/cros_install_debug_syms.py

diff --git a/scripts/cros_install_debug_syms.py b/scripts/cros_install_debug_syms.py
index 6ca8ce0..2ddfa86 100644
--- a/scripts/cros_install_debug_syms.py
+++ b/scripts/cros_install_debug_syms.py
@@ -372,14 +372,14 @@
   if not cros_build_lib.IsInsideChroot():
     raise commandline.ChrootRequiredError(argv)
 
+  options = ParseArgs(argv)
+
   cmd = [os.path.join(constants.CHROMITE_BIN_DIR,
                       'cros_install_debug_syms')] + argv
   if osutils.IsNonRootUser():
     cros_build_lib.sudo_run(cmd)
     return
 
-  options = ParseArgs(argv)
-
   # sysroot must have a trailing / as the tree dictionary produced by
   # create_trees in indexed with a trailing /.
   sysroot = build_target_lib.get_default_sysroot_path(options.board) + '/'