lint: clean up old statements
We can delete a number of disable statements that are no longer relevant,
replace the W/E/F constants with their human readable names, and scope a
few to where they're needed instead of disabling in the entire module.
BUG=None
TEST=`cros lint` is unchanged
Change-Id: Ic7ac1ab410917b075212b38412f8a1e381b8b915
Reviewed-on: https://chromium-review.googlesource.com/1135635
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
diff --git a/scripts/cros_sdk.py b/scripts/cros_sdk.py
index 1e401cb..eec06a0 100644
--- a/scripts/cros_sdk.py
+++ b/scripts/cros_sdk.py
@@ -115,13 +115,11 @@
# Note we track content length ourselves since certain versions of curl
# fail if asked to resume a complete file.
- # pylint: disable=C0301,W0631
# https://sourceforge.net/tracker/?func=detail&atid=100976&aid=3482927&group_id=976
logging.notice('Downloading %s tarball...', desc)
status_re = re.compile(r'^HTTP/[0-9]+(\.[0-9]+)? 200')
+ # pylint: disable=undefined-loop-variable
for url in urls:
- # http://www.logilab.org/ticket/8766
- # pylint: disable=E1101
parsed = urlparse.urlparse(url)
tarball_name = os.path.basename(parsed.path)
if parsed.scheme in ('', 'file'):