api/controller: Convert manual BuildTarget instantiations
There are controller_util functions to construct BuildTargets from
the protobuf messages so we can have a single place to address changes
to the protobuf message. Convert all the BuildTarget instantiations
from manual constructions to calls to the util function.
BUG=chromium:1060351
TEST=run_tests, cq
Change-Id: I60c6720cf7bbc60f122f2fa1e2e81ab13368193f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2096818
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
diff --git a/api/controller/packages.py b/api/controller/packages.py
index 201303c..de9f29d 100644
--- a/api/controller/packages.py
+++ b/api/controller/packages.py
@@ -14,7 +14,6 @@
from chromite.api.controller import controller_util
from chromite.api.gen.chromite.api import binhost_pb2
from chromite.api.gen.chromiumos import common_pb2
-from chromite.lib import build_target_lib
from chromite.lib import constants
from chromite.lib import cros_build_lib
from chromite.lib import cros_logging as logging
@@ -43,8 +42,7 @@
@validate.validation_complete
def Uprev(input_proto, output_proto, _config):
"""Uprev all cros workon ebuilds that have changes."""
- target_names = [t.name for t in input_proto.build_targets]
- build_targets = [build_target_lib.BuildTarget(t) for t in target_names]
+ build_targets = controller_util.ParseBuildTargets(input_proto.build_targets)
overlay_type = _OVERLAY_TYPE_TO_NAME[input_proto.overlay_type]
chroot = controller_util.ParseChroot(input_proto.chroot)
output_dir = input_proto.output_dir or None