commit 26e472b6108517188a477247d9872cc50fe2d229
author Alex Klein <saklein@chromium.org> Tue Mar 10 14:35:01 2020 -0600
committer Commit Bot <commit-bot@chromium.org> Wed Mar 11 19:10:39 2020 +0000
tree e59c554aa20be81bcf9e0368af6539df1463f99b
parent 62b7e1e2b7e41f88783bce5ef8b49ce0d61d5cec

api/controller: Convert manual BuildTarget instantiations

There are controller_util functions to construct BuildTargets from
the protobuf messages so we can have a single place to address changes
to the protobuf message. Convert all the BuildTarget instantiations
from manual constructions to calls to the util function.

BUG=chromium:1060351
TEST=run_tests, cq

Change-Id: I60c6720cf7bbc60f122f2fa1e2e81ab13368193f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2096818
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>

api/controller/android_unittest.py

diff --git a/api/controller/android_unittest.py b/api/controller/android_unittest.py
index fd93b02..5f44fb1 100644
--- a/api/controller/android_unittest.py
+++ b/api/controller/android_unittest.py
@@ -19,7 +19,7 @@
 from chromite.lib import cros_build_lib
 from chromite.lib import cros_test_lib
 from chromite.lib import osutils
-from chromite.lib.build_target_lib import BuildTarget
+from chromite.lib import build_target_lib
 from chromite.service import packages
 
 
@@ -39,7 +39,8 @@
     self.input_proto.build_targets.add().name = 'foo'
     self.input_proto.build_targets.add().name = 'bar'
 
-    self.build_targets = [BuildTarget('foo'), BuildTarget('bar')]
+    self.build_targets = [build_target_lib.BuildTarget('foo'),
+                          build_target_lib.BuildTarget('bar')]
 
     self.response = android_pb2.MarkStableResponse()