commit 2577e2dd1b3c1b78581bedce69033958cb4574a2
author Jack Neus <jackneus@google.com> Thu Apr 06 16:14:01 2023 +0000
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Apr 10 18:51:48 2023 +0000
tree 84c194112c76f0a02e867f2ecdee77f95c6f7df2
parent 87b55576bf1397bc211276a73955e38040911201

differentiate paygen minios failure modes

Removed boolean return value from several functions where it was
unused.

BUG=b:268762826
TEST=recipes test train, try job

Change-Id: I8d1d9f5643d7a1ad89d9a224d7d1777fec06f5c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4402549
Reviewed-by: Benjamin Shai <bshai@google.com>
Commit-Queue: Jack Neus <jackneus@google.com>
Tested-by: Jack Neus <jackneus@google.com>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: George Engelbrecht <engeg@google.com>

api/controller/payload_unittest.py

diff --git a/api/controller/payload_unittest.py b/api/controller/payload_unittest.py
index 0028d50..15f32a1 100644
--- a/api/controller/payload_unittest.py
+++ b/api/controller/payload_unittest.py
@@ -140,3 +140,19 @@
             response_code,
             controller.RETURN_CODE_UNSUCCESSFUL_RESPONSE_AVAILABLE,
         )
+
+    def testNoMiniOSPartitionMismatch(self):
+        """Test a miniOS paygen request with a partition count mismatch."""
+        patch = self.PatchObject(paygen_payload_lib, "PaygenPayload")
+        patch.side_effect = paygen_payload_lib.MiniOSPatritionMismatchException
+        response_code = payload.GeneratePayload(
+            self.minios_req, self.result, self.api_config
+        )
+        self.assertEqual(
+            self.result.failure_reason,
+            payload_pb2.GenerationResponse.MINIOS_COUNT_MISMATCH,
+        )
+        self.assertEqual(
+            response_code,
+            controller.RETURN_CODE_UNSUCCESSFUL_RESPONSE_AVAILABLE,
+        )