commit 2557b4f189a053e38124adf54117c1bcaa033152
author Alex Klein <saklein@chromium.org> Thu Jul 11 14:34:00 2019 -0600
committer Commit Bot <commit-bot@chromium.org> Fri Jul 12 03:12:43 2019 +0000
tree 7d5931fcba2e21ef266055165433a80a215d0156
parent 5d535ac6a0ffd73c90101634fdc603e9d2140a7a

sysroot.py & image.py: Add no specific packages failed condition.

Handling for when there was a failure but nothing to report.

BUG=chromium:983279
TEST=run_tests

Change-Id: I2b82492ae2b2f534f587d7f45df86fbc2ddd4ce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1697376
Commit-Queue: Alex Klein <saklein@chromium.org>
Commit-Queue: Evan Hernandez <evanhernandez@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>
Auto-Submit: Alex Klein <saklein@chromium.org>

api/controller/sysroot.py

diff --git a/api/controller/sysroot.py b/api/controller/sysroot.py
index ffa8132..0d75b9f 100644
--- a/api/controller/sysroot.py
+++ b/api/controller/sysroot.py
@@ -98,6 +98,11 @@
   try:
     sysroot.BuildPackages(build_target, target_sysroot, build_packages_config)
   except sysroot_lib.PackageInstallError as e:
+    if not e.failed_packages:
+      # No packages to report, so just exit with an error code.
+      return controller.RETURN_CODE_COMPLETED_UNSUCCESSFULLY
+
+    # We need to report the failed packages.
     for package in e.failed_packages:
       package_info = output_proto.failed_packages.add()
       controller_util.CPVToPackageInfo(package, package_info)