commit 1ffc275df5ed0686e30b0ac184214910099312fc
author Boleyn Su <boleynsu@google.com> Fri Dec 18 07:16:17 2020 +0900
committer Commit Bot <commit-bot@chromium.org> Mon Dec 21 03:12:44 2020 +0000
tree 3b3953576af7efd5af6d4c34e32bc3b26027a4f3
parent f4748bc80292b97f48d8703e801bbd26b5880b68

android.py: tracking_branch should be optional

|tracking_branch| is not required so we should not
call validate.require on it.

BUG=b:175901991
TEST=CQ

Change-Id: Ia8580bc5e6087936118421be4217d361d538ebda
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2596699
Commit-Queue: Boleyn Su <boleynsu@chromium.org>
Tested-by: Boleyn Su <boleynsu@chromium.org>
Reviewed-by: LaMont Jones <lamontjones@chromium.org>

api/controller/android.py

diff --git a/api/controller/android.py b/api/controller/android.py
index cb2e2a3..b3fe214 100644
--- a/api/controller/android.py
+++ b/api/controller/android.py
@@ -35,7 +35,7 @@
 
 @faux.success(_MarkStableResponse)
 @faux.empty_error
-@validate.require('tracking_branch', 'package_name', 'android_build_branch')
+@validate.require('package_name', 'android_build_branch')
 @validate.validation_complete
 def MarkStable(input_proto, output_proto, _config):
   """Uprev Android, if able.

api/controller/android_unittest.py

diff --git a/api/controller/android_unittest.py b/api/controller/android_unittest.py
index 7fdca0e..2be0ce9 100644
--- a/api/controller/android_unittest.py
+++ b/api/controller/android_unittest.py
@@ -57,13 +57,6 @@
                      'android-package-name')
     self.assertEqual(self.response.android_atom.version, '1.2')
 
-  def testFailsIfTrackingBranchMissing(self):
-    """Fails if tracking_branch is missing."""
-    self.input_proto.tracking_branch = ''
-    with self.assertRaises(cros_build_lib.DieSystemExit):
-      android.MarkStable(self.input_proto, self.response, self.api_config)
-    self.uprev.assert_not_called()
-
   def testFailsIfPackageNameMissing(self):
     """Fails if package_name is missing."""
     self.input_proto.package_name = ''